Skip to content

Nuvoton: Optimize spi_master_write(...) in case of no SPI MISO pin #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

Nuvoton: Optimize spi_master_write(...) in case of no SPI MISO pin #12454

merged 1 commit into from
Feb 19, 2020

Conversation

@ccli8
Copy link
Contributor

@ccli8 ccli8 commented Feb 18, 2020

Summary of changes

This PR tries to optimize spi_master_write(...) in case of no SPI MISO pin. It does so by skipping SPI read so that no more FIFO write/read delay contribute to SPI inter-frame delay when data is written successively.

Update Nuvoton targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NU_PFM_M2351_*
  • NUMAKER_IOT_M263A
  • NUMAKER_M252KG

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: Make SPI inter-frame (delay match configured suspend interval
8df96ec 
In no MISO case, skip SPI read so that no more write/read delay contribute to SPI inter-frame delay when data is written successively.

Update targets:
-   NUMAKER_PFM_NANO130
-   NUMAKER_PFM_NUC472
-   NUMAKER_PFM_M453
-   NUMAKER_PFM_M487/NUMAKER_IOT_M487
-   NU_PFM_M2351_*
-   NUMAKER_IOT_M263A
-   NUMAKER_M252KG
@ciarmcom ciarmcom requested review from a team and Ronny-Liu February 18, 2020 08:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 18, 2020

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@ccli8 ccli8 mentioned this pull request Feb 18, 2020
Closed
@mergify mergify bot added needs: CI and removed needs: review labels Feb 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 18, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 043f68b into ARMmbed:master Feb 19, 2020
@mergify mergify bot removed the ready for merge label Feb 19, 2020
@cyliangtw cyliangtw deleted the nuvoton_spi_no_miso branch March 9, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

1 more reviewer

@bulislaw bulislaw bulislaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ccli8 @ciarmcom @0xc0170 @mbed-ci @bulislaw