Skip to content

STM32 TRACE_GROUP update #12453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

STM32 TRACE_GROUP update #12453

merged 1 commit into from
Feb 19, 2020

Conversation

@jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Feb 17, 2020

Summary of changes

From
https://github.com/ARMmbed/mbed-trace#compromises

=> The group name length is limited to four characters

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
STM32 TRACE_GROUP update
f000b87 
Only 4 characters is allowed
@ciarmcom ciarmcom requested review from a team February 17, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 17, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 18, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 69a0542 into ARMmbed:master Feb 19, 2020
@mergify mergify bot removed the ready for merge label Feb 19, 2020
@jeromecoutant jeromecoutant deleted the PR_TRACEGROUP branch February 20, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@bulislaw bulislaw bulislaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @bulislaw