Skip to content

Nordic NRF52 GPIO API: Fix non-deterministic failure to configure interrupt handling #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

Nordic NRF52 GPIO API: Fix non-deterministic failure to configure interrupt handling #12431

merged 1 commit into from
Feb 19, 2020

Conversation

@the-real-blackh
Copy link

@the-real-blackh the-real-blackh commented Feb 13, 2020

Summary of changes

Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setup' in a local
gpiote input configuration data structure, resulting in non-deterministic failure
to initialize interrupt handling.

Impact of changes

Makes the behaviour deterministic.

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Nordic NRF52 GPIO API: Fix failure to clear the field 'skip_gpio_setu…
e9dd602 
…p' in a local

gpiote input configuration data structure, resulting in non-deterministic failure
to initialize interrupt handling.
@ciarmcom ciarmcom requested a review from a team February 13, 2020 22:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 13, 2020

@the-real-blackh, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 17, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 17, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 17, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 664000a into ARMmbed:master Feb 19, 2020
@mergify mergify bot removed the ready for merge label Feb 19, 2020
@supertoast supertoast mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@the-real-blackh @ciarmcom @0xc0170 @mbed-ci