Skip to content

Conversation

@mprse
Copy link
Contributor

@mprse mprse commented Feb 3, 2020

Summary of changes

According to the description in gpio_irq_hal_api.h file gpio_irq_init() should return 0 on success:

* @return -1 if pin is NC, 0 otherwise

Currently, it returns 1 causing the FPGA test to fail.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond @maciejbocianski @fkjagodzinski @0xc0170


Acording to the description in `gpio_irq_hal_api.h` file `gpio_irq_init()` should return 0 on success.
Currently, it returns 1 causing the FPGA test to fail.
@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@mprse, thank you for your changes.
@fkjagodzinski @maciejbocianski @jamesbeyond @0xc0170 @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 4, 2020
@0xc0170 0xc0170 merged commit f73a62a into ARMmbed:master Feb 4, 2020
@mergify mergify bot removed the ready for merge label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants