Skip to content

Conversation

@mprse
Copy link
Contributor

@mprse mprse commented Feb 3, 2020

Summary of changes

FPGA SPI test fails while testing asynchronous mode.

It looks like low-level-lpticker-wrapper latency causes issue similar to #8714 and #9785, especially with SPI async which use interrupts.

Related PR: #11713

I remember that we have added low-level-lpticker-wrapper to enable tickles mode, but unfortunately, it is still causing problems with SPI async mode. Verified that with tickles disabled test passes. The test also passes if I increase transmission speed.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Please review @LMESTM @jeromecoutant @jamesbeyond


FPGA SPI test fails while testing asynchronous mode.
It looks like  low-level-lpticker-wrapper latency causes issue similar to ARMmbed#8714 and ARMmbed#9785, especially with SPI async which use interrupts.
@ciarmcom ciarmcom requested review from a team, LMESTM, jamesbeyond and jeromecoutant February 3, 2020 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@mprse, thank you for your changes.
@jeromecoutant @jamesbeyond @LMESTM @ARMmbed/mbed-os-maintainers please review.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

We don't want to remove TICKLESS from STM32L0.

@ABOSTM is going to check this SPI issue

Regards,

@ABOSTM
Copy link
Contributor

ABOSTM commented Feb 4, 2020

Hi @mprse ,
As said @jeromecoutant , we don't want to disable tickless for L0 family because those chips are specially design for LowPower.
Another alternative would be to disable SPI async mode for L0, but instead, we proposed a change in STM32 Cube HAL behavior to prevent overrun in case of SPI async. As it impacts performances, it is applies only to L0 family.
So I propose to cancel the current PR, and instead use:
#12362

@mprse mprse closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants