-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove _LIBCPP_EXTERN_TEMPLATE ARMCC compilation flag #12302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _LIBCPP_EXTERN_TEMPLATE ARMCC compilation flag #12302
Conversation
|
@michalpasztamobica, thank you for your changes. |
mark-edgeworth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested by me, but the code change looks good.
|
@pan- @kjbracey-arm @AnttiKauppila could you please review ? |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This PR does not contain release version label after merging. |
|
I've fixed the version: Set to 6.0.0-alpha-2 |
Summary of changes
The flag was added in #5993.
As per comment from @pan- , the flag is not necessary once libc++ is shipped with ARMCC.
According to Arm compiler 6.11 release notes:
The particular reason I am interested in removing the flag is that it gives compilation warnings if library functions are put to use (see #12300):
Impact of changes
Smaller image size, as the units definitions will not be copied into every compilation unit and we are linking against libc++ anyway.
Warnings about duplicate symbols, when libc++ is being used should go away.
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-tools
@AnttiKauppila
@kjbracey-arm