Skip to content

Cellular: Remove deprecated CellularDevice::stop() #12249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Cellular: Remove deprecated CellularDevice::stop() #12249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions UNITTESTS/features/cellular/framework/device/cellulardevice/cellulardevicetest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,6 @@ TEST_F(TestCellularDevice, test_get_context_list)
delete dev;
}

TEST_F(TestCellularDevice, test_stop)
{
FileHandle_stub fh1;
CellularDevice *dev = new myCellularDevice(&fh1);
EXPECT_TRUE(dev);

CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_OK);

dev->stop();
delete dev;
}

TEST_F(TestCellularDevice, test_cellular_callback)
{
FileHandle_stub fh1;
Expand Down
6 changes: 0 additions & 6 deletions features/cellular/framework/API/CellularDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,12 +377,6 @@ class CellularDevice {

public: //Common functions

/** Stop the current operation. Operations: set_device_ready, set_sim_ready, register_to_network, attach_to_network
*
*/
MBED_DEPRECATED_SINCE("mbed-os-5.15", "Use CellularDevice::shutdown() instead.")
void stop();

/** Get the current FileHandle item used when communicating with the modem.
*
* @return reference to FileHandle
Expand Down
6 changes: 0 additions & 6 deletions features/cellular/framework/device/CellularDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ CellularDevice::~CellularDevice()
delete _state_machine;
}

void CellularDevice::stop()
{
MBED_ASSERT(_state_machine);
_state_machine->stop();
}

FileHandle &CellularDevice::get_file_handle() const
{
return *_fh;
Expand Down