-
Notifications
You must be signed in to change notification settings - Fork 3k
LPC11U24: Fix baremetal build and runtime error #12155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hugueskamba, thank you for your changes. |
|
I don't think that will work, even if it compiles. I think the us ticker is required: mbed-os/platform/source/mbed_os_timer.cpp Line 44 in 5e69377
@kjbracey-arm do you remember why is it an assert not compile time error? Also there's some commented out code there |
|
Looking at mbed_os_timer, it should work (it requires us ticket only if sleep from us ticker is enabled?). us ticker is not requirement (there is a fallback for wait() to use ns instead). However mbed os timer needs a ticker. plus @kjbracey-arm Please review |
|
Hm will it run tests? I remember back in the day usticker was a dependency. |
Me as well. Surprised to see a target without us ticker. I would expect having this target disabled but if no one has objected until now - was it used or not? |
|
The change was already merged by the PR #12134 @hugueskamba
|
* Add `USTICKER` support for `LPC11U24`. * Add `tickless-from-us-ticker` and `boot-stack-size` overrides.
6928df7 to
15bf72e
Compare
|
|
I'll run this through CI while awaiting the review |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Summary of changes
USTICKERsupport forLPC11U24.tickless-from-us-tickerandboot-stack-sizeoverrides.Impact of changes
It is now possible to build
LPC11U24with the baremetal profile.i.e It is now possible to build
mbed-os-example-blinky-baremetalwith$ mbed compile -t gcc_arm -m lpc11u24Migration actions required
Documentation
Pull request type
Test results
Reviewers
@mprse