Skip to content

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 20, 2019

Summary of changes

  • Add USTICKER support for LPC11U24.
  • Add tickless-from-us-ticker and boot-stack-size overrides.

Impact of changes

It is now possible to build LPC11U24 with the baremetal profile.
i.e It is now possible to build mbed-os-example-blinky-baremetal with $ mbed compile -t gcc_arm -m lpc11u24

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mprse


@ciarmcom ciarmcom requested review from a team, maclobdell and mprse December 20, 2019 16:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@mprse @maclobdell @ARMmbed/mbed-os-maintainers please review.

@bulislaw
Copy link
Member

I don't think that will work, even if it compiles. I think the us ticker is required:

OsTimer *init_os_timer()

@kjbracey-arm do you remember why is it an assert not compile time error? Also there's some commented out code there

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

Looking at mbed_os_timer, it should work (it requires us ticket only if sleep from us ticker is enabled?). us ticker is not requirement (there is a fallback for wait() to use ns instead).

However mbed os timer needs a ticker.

plus https://github.com/ARMmbed/mbed-os/blob/5e693778f46a0c349159a1aab8347151c0022db9/platform/source/mbed_os_timer.cpp#L58 should be removed as noted.

@kjbracey-arm Please review

@0xc0170 0xc0170 requested a review from kjbracey January 2, 2020 14:09
@bulislaw
Copy link
Member

bulislaw commented Jan 3, 2020

Hm will it run tests? I remember back in the day usticker was a dependency.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

Hm will it run tests? I remember back in the day usticker was a dependency.

Me as well. Surprised to see a target without us ticker. I would expect having this target disabled but if no one has objected until now - was it used or not?

@toyowata
Copy link
Contributor

toyowata commented Jan 6, 2020

The change was already merged by the PR #12134

@hugueskamba
To fix baremetal build error and runtime failure for the target, you will need to:-

* Add `USTICKER` support for `LPC11U24`.
* Add `tickless-from-us-ticker` and `boot-stack-size` overrides.
@hugueskamba hugueskamba force-pushed the hk-baremetal-lpc11uxx-fix branch from 6928df7 to 15bf72e Compare January 6, 2020 08:47
@hugueskamba hugueskamba changed the title LPC11UXX: Fix baremetal linker error LPC11U24: Fix baremetal build and runtime error Jan 6, 2020
@hugueskamba
Copy link
Collaborator Author

The change was already merged by the PR #12134

@hugueskamba
To fix baremetal build error and runtime failure for the target, you will need to:-

Thanks @toyowata
Done.

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

I'll run this through CI while awaiting the review

@mbed-ci
Copy link

mbed-ci commented Jan 6, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Jan 7, 2020
@0xc0170 0xc0170 merged commit 7d8eec4 into ARMmbed:master Jan 7, 2020
@hugueskamba hugueskamba deleted the hk-baremetal-lpc11uxx-fix branch June 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants