Skip to content

Conversation

@evedon
Copy link
Contributor

@evedon evedon commented Nov 28, 2019

Description

Summary of change

Two recent PRs introduced compilation errors when building greentea tests with bare metal profile:

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

These errors were found because we are introducing nightly CI for bare metal greentea tests.

Reviewers


@SeppoTakalo @fkjagodzinski

Release Notes

Summary of changes

Impact of changes

Migration actions required

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2019

#11851 We need to include fat_chan to build bare metal greentea tests due to this PR.

That PR just added configuration file for a library, no other changes . Did it break baremetal?

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@evedon
Copy link
Contributor Author

evedon commented Nov 28, 2019

#11851 We need to include fat_chan to build bare metal greentea tests due to this PR.

That PR just added configuration file for a library, no other changes . Did it break baremetal?

Yes, same failures as described here: #11851 (comment)

@mbed-ci
Copy link

mbed-ci commented Nov 28, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 0b12108 into ARMmbed:master Nov 29, 2019
@evedon evedon deleted the ed-baremetal-fixes branch January 9, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants