Skip to content

Conversation

@AnttiKauppila
Copy link

Added missing "return" for NetworkStackMock's get_stack() method

Description

Summary of change

nsapi_dns unittest is crashing in local environment due to missing return in NetworkStackMock's get_stack() function. This PR adds the missing return and fixes the problem.

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@michalpasztamobica


Release Notes

Summary of changes

Impact of changes

Migration actions required

Added missing "return" for NetworkStackMock's get_stack() method
@ciarmcom ciarmcom requested review from a team and michalpasztamobica November 28, 2019 10:00
@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 28, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a467f0c into master Nov 28, 2019
@0xc0170 0xc0170 removed the needs: CI label Nov 28, 2019
@AnttiKauppila AnttiKauppila deleted the AnttiKauppila-patch-1 branch November 28, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants