Skip to content

Minimal Console: Fix syntax errors #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

Minimal Console: Fix syntax errors #11947

merged 1 commit into from
Nov 27, 2019

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Nov 26, 2019

Description

Summary of change

Fix syntax error that prevent building when "platform.stdio-minimal-console-only" is true.

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

See: #11796 (comment)

Reviewers

@evedon @rajkan01

Release Notes

Summary of changes

Impact of changes

Migration actions required

0xc0170
0xc0170 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No nightly failures for these?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2019

Set to 5.15 as it fixing the feature there.

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Nov 26, 2019 •
edited
Loading

No nightly failures for these?

No because the parameter is false by default. See details in this PR description what was agreed to be done in terms of testing.

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

Test restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

CI restarted

@0xc0170 0xc0170 removed the needs: CI label Nov 27, 2019
@0xc0170 0xc0170 merged commit 394cf7a into ARMmbed:master Nov 27, 2019
@hugueskamba hugueskamba deleted the hk-fix-minimal-console branch November 27, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees

No one assigned

Labels

release-version: 5.15.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugueskamba @0xc0170 @mbed-ci @evedon