Skip to content

Conversation

@yarbcy
Copy link
Contributor

@yarbcy yarbcy commented Nov 20, 2019

Description (required)

Summary of change (What the change is for and why)

I2C byte read/write transmition improvement

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes

Issue while calling - "MASTER_IS_NOT_READY":

i2c_start(&i2c);
i2c_byte_write(&i2c, (I2C_DEV_ADDR | 1));//send device address for reading
data_in[i] = i2c_byte_read(&i2c, 1);

Added CY_SCB_I2C_READ_XFER to clear CY_SCB_I2C_WRITE_XFER status in i2c_byte_write() API.

Impact of changes

Cypress

Migration actions required

N/A

@ciarmcom ciarmcom requested review from a team and maclobdell November 20, 2019 12:00
@ciarmcom
Copy link
Member

@yarbcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 20, 2019

@0xc0170 Please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

@yarbcy Can you rebase to clean up the merge commits, to have your git history linear for this PR?

Ari Parkkila and others added 15 commits November 20, 2019 15:59
Run WIFI-GET-RSSI and WIFI-CONNECT-DISCONNECT-REPEAT tests in secure mode
Remove WIFI-CONNECT-PARAMS-VALID-UNSECURE, it's duplicate to WIFI_CONNECT with remains moved to WIFI-CONNECT-SECURE
For non-rtos build (bare metal) cellular event queue is now scheduled by shared event queue.
Some packet loss may be expected/allowed with UDP.
Set socket timeout to continue testing if no response is received within a timeout.
Currently mbed-os-example-blinky and mbed-os-example-wifi are built for each and every target in Mbed OS. This will change that only DISCO_L475VG_IOT01A is built for mbed-os-example-wifi. DISCO_L475VG_IOT01A was chosen as its one of the wi-fi supported boards and having integrated wi-fi.
Ticless on STM32 F4 boards causes SPI issue with following PR:
# 11682 Make FPGA tests to pass on CI targets (SPI, analogIn, PWM)

In asynch mode, using interrupts, SPI hardware detect an RX overrun.
Our understanding is that lpticker wrapper latency
causes issue similar to ARMmbed#8714 and ARMmbed#9785,
specially with SPI asynch which use interrupts.
@yarbcy yarbcy force-pushed the pr/i2c-improvement branch from 80dc1bd to e58003f Compare November 20, 2019 14:10
@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 20, 2019

Created new
#11908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants