Skip to content

Fixes to PR template #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2019
Merged

Fixes to PR template #11899

merged 2 commits into from
Nov 21, 2019

Conversation

@bulislaw
Copy link
Member

@bulislaw bulislaw commented Nov 19, 2019

Description (required)

Summary of change (What the change is for and why)

Various changes including:
Fix header levels
Fix typos
Move more text to comments

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@0xc0170

@bulislaw
Some fixes to PR
422e59f 
Various changes including:
Fix header levels
Fix typos
Move more text to comments
@ciarmcom ciarmcom requested review from a team and 0xc0170 November 19, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 19, 2019

@bulislaw, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 requested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one correction, otherwise +1

.github/pull_request_template.md Outdated
<!--
All 3 sections are compulsory for Major PR types. For Feature PRs only the summary section is required.
This section is automatically added to release notes. Please fill in each sub-section with sufficient detail for a user.
This section is automatically added to release notes. Please fill in each sub-section with sufficient detail for an user.
Copy link
Contributor

@0xc0170 0xc0170 Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was correct as it was

Copy link
Member Author

@bulislaw bulislaw Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bulislaw
Fix an article
dd7f557 
An -> A for "user"
@0xc0170 0xc0170 requested a review from adbridge November 21, 2019 10:40
adbridge
adbridge approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me

@0xc0170 0xc0170 merged commit 30bab09 into master Nov 21, 2019
@0xc0170 0xc0170 deleted the feature-pr-template-bulislaw branch November 21, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

Assignees

No one assigned

Labels

release-version: 5.15.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bulislaw @ciarmcom @0xc0170 @adbridge