Skip to content

Fix for Cypress GPIO driver (fix for issue #11835) #11867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix for Cypress GPIO driver (fix for issue #11835) #11867

merged 1 commit into from
Nov 19, 2019

Conversation

@mprse
Copy link
Contributor

@mprse mprse commented Nov 14, 2019

Description (required)

Fix for issue #11835.
NOT TESTED!

@yarbcy Can you test this fix?

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170

@mprse mprse mentioned this pull request Nov 14, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 14, 2019

@ARMmbed/team-cypress Please review and test (cc @yarbcy )

@ciarmcom ciarmcom requested review from a team, 0xc0170 and maclobdell November 14, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 14, 2019

@mprse, thank you for your changes.
@0xc0170 @maclobdell @ARMmbed/mbed-os-maintainers please review.

yarbcy
yarbcy approved these changes Nov 18, 2019
View reviewed changes
targets/TARGET_Cypress/TARGET_PSOC6/gpio_object.h Outdated
MBED_ASSERT(obj->pin != CYHAL_NC_PIN_VALUE);
cyhal_gpio_write(obj->pin, value != 0);
} else {
obj->output_val == value;
Copy link
Contributor

@yarbcy yarbcy Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this typo.

@yarbcy
Copy link
Contributor

yarbcy commented Nov 18, 2019

@0xc0170 Please update CI.

@yarbcy
Copy link
Contributor

yarbcy commented Nov 18, 2019

@maclobdell @adbridge Can you guys help with CI restart ?

@adbridge
Copy link
Contributor

adbridge commented Nov 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a183033 into ARMmbed:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adbridge adbridge adbridge approved these changes

@0xc0170 0xc0170 Awaiting requested review from 0xc0170

@maclobdell maclobdell Awaiting requested review from maclobdell

+1 more reviewer

@yarbcy yarbcy yarbcy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

devices: cypress release-version: 5.15.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mprse @0xc0170 @ciarmcom @yarbcy @adbridge @mbed-ci