Skip to content

Adding set baud rate routine #11783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2019
Merged

Adding set baud rate routine #11783

merged 2 commits into from
Nov 4, 2019

Conversation

@mirelachirica
Copy link
Contributor

@mirelachirica mirelachirica commented Oct 31, 2019 •
edited
Loading

Description (required)

Added set baud rate routines for cellular devices.

Pull request type (required)

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@AriParkkila

@ciarmcom ciarmcom requested review from a team and AriParkkila October 31, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 31, 2019

@mirelachirica, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Oct 31, 2019
@mbed-ci
Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

AriParkkila
AriParkkila approved these changes Nov 1, 2019
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see also comments/questions.

features/cellular/framework/AT/AT_CellularDevice.cpp
_at->set_baud(baud_rate);

// Give some time before starting using the UART with the new baud rate
rtos::ThisThread::sleep_for(3000);
Copy link

@AriParkkila AriParkkila Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could poll with an AT command to make it more responsive?

TESTS/netsocket/tcp/tcpsocket_recv_100k.cpp
{
SKIP_IF_TCP_UNSUPPORTED();

#ifdef MBED_CONF_APP_BAUD_RATE
Copy link

@AriParkkila AriParkkila Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be modem specific config?

@mirelachirica mirelachirica changed the title Adding set/get baud rate routines Adding set baud rate routine Nov 1, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit c908404 into ARMmbed:master Nov 4, 2019
@0xc0170 0xc0170 added release-version: 5.15.0-rc1 and removed release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.15.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mirelachirica @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila