Skip to content

Fix Quectel M26 context hang #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

Fix Quectel M26 context hang #11717

merged 1 commit into from
Oct 21, 2019

Conversation

@iliapenev
Copy link
Contributor

@iliapenev iliapenev commented Oct 20, 2019

Description

Fix Quectel M26 hang on connect().

_at.lock() is acquired but not released in QUECTEL_M26::get_sim_state(SimState &state)

Tested with custom Quectel MC60, which uses Quectel M26 driver

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@iliapenev iliapenev mentioned this pull request Oct 20, 2019
Closed
@ciarmcom
Copy link
Member

ciarmcom commented Oct 20, 2019

@iliapenev, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team October 20, 2019 23:00
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2019

Exporters restarted (internal error)

@0xc0170 0xc0170 removed the needs: CI label Oct 21, 2019
@0xc0170 0xc0170 merged commit 9534327 into ARMmbed:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@kivaisan kivaisan kivaisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.14.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iliapenev @ciarmcom @0xc0170 @mbed-ci @kivaisan