Skip to content

Conversation

@jeromecoutant
Copy link
Collaborator

Description

Hi

Input parameter of pinmap_peripheral function is the PinName.
When application set the wrong pin value, error code displays the peripheral value, which doesn't help the developper.

Proposition is to display the function input parameter, i.e. pin value.

Thx

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team October 3, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. 👍

There is another function (pinmap_function()) that displays NC instead of more valuable info. Could you also update that error message as part of this PR?

MBED_ERROR1(MBED_MAKE_ERROR(MBED_MODULE_PLATFORM, MBED_ERROR_CODE_PINMAP_INVALID), "pinmap not found for function", function);

@jeromecoutant
Copy link
Collaborator Author

There is another function (pinmap_function()) that displays NC instead of more valuable info. Could you also update that error message as part of this PR?

done

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 3ca2e14 into ARMmbed:master Oct 14, 2019
@jeromecoutant jeromecoutant deleted the PR_PINMAP_ERROR branch October 14, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants