Skip to content

IOTBTOOL-407 Fix microbit to use Arm C5 #11609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2019
Merged

IOTBTOOL-407 Fix microbit to use Arm C5 #11609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion targets/targets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5318,7 +5318,8 @@
"inherits": ["MCU_NRF51_16K_S110"],
"macros_add": ["TARGET_NRF_LFCLK_RC"],
"release_versions": ["2"],
"device_name": "nRF51822_xxAA"
"device_name": "nRF51822_xxAA",
"supported_toolchains": ["ARMC5", "GCC_ARM"]
Copy link
Member

@bulislaw bulislaw Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only ARMC and GCC and not IAR?

Copy link
Contributor Author

@madchutney madchutney Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NRF51_MICROBIT inherits from MCU_NRF51_16K_S110 which inherits from MCU_NRF51_S110 and MCU_NRF51_16K_BASE. MCU_NRF51_S110 is a dead end and does not define a toolchain. So following MCU_NRF51_16K_BASE this inherits from MCU_NRF51, which defines the supported_toolchains as [“ARM", "GCC_ARM”]. This means before my change the supported toolchains were Arm C6 and GCC ARM, but before the change which broke microbit they should have been Arm C5 and GCC ARM. This definition seems to be setup in 2016, which means as best as I can tell this platform has never declared support for IAR.

Copy link
Contributor

@0xc0170 0xc0170 Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to check this one as well as I would have assumed nrf51 was supported also by IAR but has not been.

},
"NRF51_MICROBIT_BOOT": {
"inherits": ["MCU_NRF51_16K_BOOT_S110"],
Expand Down