Skip to content

Tests: USB: Update error handling in basic tests #11540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2019
Merged

Tests: USB: Update error handling in basic tests #11540

merged 5 commits into from
Sep 30, 2019

Conversation

@fkjagodzinski
Copy link
Member

Description

This patch updates the error handling in a host script used for the generic USB device tests. I've cleaned up the formatting so that the user can see the cause of a test failure more clearly.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@maciejbocianski

Release Notes

@fkjagodzinski fkjagodzinski mentioned this pull request Sep 20, 2019
Closed
@ciarmcom ciarmcom requested review from a team and maciejbocianski September 20, 2019 13:00
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@maciejbocianski @ARMmbed/mbed-os-maintainers please review.

@fkjagodzinski fkjagodzinski force-pushed the test_update-usb_device-basic branch from f43157b to 0e89cb6 Compare September 27, 2019 12:14
maciejbocianski
maciejbocianski approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@maciejbocianski maciejbocianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkjagodzinski fkjagodzinski force-pushed the test_update-usb_device-basic branch from 0e89cb6 to 5432bb9 Compare September 30, 2019 09:57
@fkjagodzinski
Copy link
Member Author

Rebased on current master to resolve conflicts.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit cd8753a into ARMmbed:master Sep 30, 2019
@fkjagodzinski fkjagodzinski deleted the test_update-usb_device-basic branch September 30, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@maciejbocianski maciejbocianski maciejbocianski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.14.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fkjagodzinski @ciarmcom @0xc0170 @mbed-ci @maciejbocianski