Fix USB tests working with python 3 #11520
Conversation
|
@fkjagodzinski could you have a look? |
fkjagodzinski
left a comment
fkjagodzinski
left a comment
There was a problem hiding this comment.
@OPpuolitaival did you have any problems with these lines? I run usb tests on latest master d0b5ba6 with Python3 and these did not cause problems. I had to update other lines though -- fkjagodzinski@96581ff. Feel free to cherry-pick this patch here.
| try: | ||
| ret = get_descriptor(dev, (DESC_TYPE_DEVICE << 8) | (0 << 0), 0, DEVICE_DESC_SIZE) | ||
| dev_desc = dict(zip(device_descriptor_keys, device_descriptor_parser.unpack(ret))) | ||
| dev_desc = dict(list(zip(device_descriptor_keys, device_descriptor_parser.unpack(ret)))) |
There was a problem hiding this comment.
No need to make a list here. dict() can handle generators just fine.
| mbed_serial.reset_output_buffer() | ||
| mbed_serial.dtr = True | ||
| for byteval in itertools.chain(reversed(range(0x100)), range(0x100)): | ||
| for byteval in itertools.chain(reversed(list(range(0x100))), list(range(0x100))): |
There was a problem hiding this comment.
No need to add list() here.
|
I tried to verify these changes on MAC - usb tests still FAILED... |
|
On Windows I saw the same errors... |
|
I did use 2to3 for these changes.. that normally find out problems quite well |
Yeah, the changes seem reasonable in general as they cover tha API changes (generators returned instead of objects). In this particular case these changes are unnecessary. |
|
Cannot test with Mac. I ask my colleague to test this on Windows |
7 participants
Description
Fix USB related host_test python scripts to work on python 3 also
Pull request type
Reviewers
@jussisip could you test this?
Release Notes