update googletest to v1.8.1 #11486
Merged
update googletest to v1.8.1 #11486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ladislas, thank you for your changes. |
Contributor
👍 for using the version rather than SHA @ARMmbed/mbed-os-test Please review |
Contributor
|
@ARMmbed/mbed-os-test bump - please review (@jamesbeyond fyi) |
jamesbeyond
suggested changes
Sep 27, 2019
Contributor
jamesbeyond
left a comment
jamesbeyond
left a comment
There was a problem hiding this comment.
Could you add a line in the readme:
https://github.com/ARMmbed/mbed-os/blob/master/UNITTESTS/README.md#writing-unit-tests
Saying this is using google tests v1.8.1 ?
0xc0170
approved these changes
Sep 30, 2019
OPpuolitaival
approved these changes
Sep 30, 2019
Contributor
Author
|
@jamesbeyond Just updated the readme, let me know if it works for you! |
0xc0170
approved these changes
Sep 30, 2019
jamesbeyond
approved these changes
Sep 30, 2019
Contributor
jamesbeyond
left a comment
jamesbeyond
left a comment
There was a problem hiding this comment.
Looks good! thanks @ladislas
Contributor
|
CI started |
0xc0170
added
release-version: 5.14.1
ready for merge
needs: CI
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updated googletest to v1.8.1. It avoids having a "random" commit used.
Tested with
cmake ..and gcc on macOS,but could not testAND withmbed test --unittestsbut could not complete (see #11485) -- googletest compiles correctly at the beginning though.The update needs a small change in CMakeLists.txt, based on that: google/googletest#1764 (comment)
Pull request type
Reviewers
n/a
Release Notes
n/a