Skip to content

Change reset_reason test timeout. #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2019
Merged

Change reset_reason test timeout. #11483

merged 1 commit into from
Sep 30, 2019

Conversation

@Tharazi97
Copy link
Contributor

@Tharazi97 Tharazi97 commented Sep 13, 2019

Description

Changed mbed_drivers-reset_reason and mbed_hal-reset_reason tests because sometimes for some devices it was a little bit to short. For example K64F was sometimes failing this test and when it passes it took it long time.

mbedgt: test suite 'tests-mbed_drivers-reset_reason' ................................................. OK in 55.23 sec

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@maciejbocianski @fkjagodzinski @jamesbeyond

Release Notes

@Tharazi97
Change reset_reason timeout.
b481e15 
Changed mbed_drivers-reset_reason and mbed_hal-reset_reason tests
because sometimes for some devices it was a little bit to short.
@ciarmcom
Copy link
Member

ciarmcom commented Sep 13, 2019

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @fkjagodzinski @ARMmbed/mbed-os-core @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed request for a team September 13, 2019 14:02
fkjagodzinski
fkjagodzinski approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

adbridge commented Sep 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2019

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

CI restarted (internal fault)

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit cead258 into ARMmbed:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

@maciejbocianski maciejbocianski Awaiting requested review from maciejbocianski

+1 more reviewer

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.14.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Tharazi97 @ciarmcom @adbridge @mbed-ci @0xc0170 @fkjagodzinski