Cellular: Disable cellular.clear-on-connect by default #11469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
jarvte
approved these changes
Sep 12, 2019
|
If we are changing the config, this even might be a fix but breaking, isn't it ? Thus the next minor version. Wait, I've noticed release notes just now. all good, 5.15 |
mirelachirica
approved these changes
Sep 16, 2019
0xc0170
approved these changes
Sep 16, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Closed
adbridge
added
release-version: 6.0.0-alpha-1
0xc0170
added
release-version: 5.15.0-rc1
and removed
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable
cellular.clear-on-connectconfiguration by default. It was a bit too bold assumption that it ca be always enabled, as it seems that clearing of PDP contexts may cause different kind of connectivity problems depending on a network environment confguration, such as auto-reconnect to network, create initial network context, SIM pin query disabled/enabled.This change disables just automatic clearing, while
CellularDevice::clear()API is still available for applications as previously.Pull request type
Reviewers
Release Notes
The release notes of PR #11414 are not anymore valid, as there is no change in functionality.