Move script to check for floats and make it Python 2 compatible #11429

hugueskamba · 2019-09-06T08:57:54Z

Description

All scripts pertaining to example projects tests should be in the same
directory. The test framework uses Python2 therefore this script also needs
to be Python2 compatible.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @evedon

Release Notes

ciarmcom · 2019-09-06T09:00:23Z

@hugueskamba, thank you for your changes.
@evedon @jamesbeyond @maclobdell @ARMmbed/mbed-os-core @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-tools please review.

tools/test/examples/examples_lib.py

tools/test/examples/examples.py

tools/test/examples/examples_lib.py

0xc0170 · 2019-09-06T10:45:55Z

There's already conflict, pls rebase

@ARMmbed/mbed-os-tools Please review

0xc0170 · 2019-09-06T11:33:32Z

Please rebase instead of merge (6a9d989 commit)

hugueskamba · 2019-09-06T12:38:51Z

Please rebase instead of merge (6a9d989 commit)

@0xc0170
This force-push rebased from master and squashed all commits.

hugueskamba · 2019-09-06T14:23:35Z

This force-push removes nanostack-border-router from the list of example projects not to run the floating point post build check as it also currently does not have any floating point operations.

hugueskamba · 2019-10-18T13:44:07Z

This force-push removes all changes to examples.py and examples_lib.py as they have been incorporated to #11710.

0xc0170 · 2019-10-18T14:06:55Z

CI restarted (aborted old job)

mbed-ci · 2019-10-18T14:26:15Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

hugueskamba · 2019-10-18T14:33:26Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR

jenkins-ci/mbed-os-ci_build-ARM

jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170 I do not believe the failures are caused by the changes in this PR.

mbed-ci · 2019-10-18T17:14:23Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

0xc0170 · 2019-10-21T07:14:57Z

@hugueskamba Tests passed in CI but Travis shows python errors, please verify

hugueskamba · 2019-10-21T12:19:28Z

This force-push removes collection unpacking and usages of Python 3.7 f-strings in the Pytest test file to fix the CI error.

0xc0170 · 2019-10-21T12:26:48Z

CI restarted

mbed-ci · 2019-10-21T12:58:27Z

Test run: FAILED

Summary: 7 of 11 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage
jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_cloud-client-test
jenkins-ci/mbed-os-ci_exporter
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM

0xc0170 · 2019-10-21T12:58:34Z

Aborted ^^

All scripts pertaining to example projects tests should be in the same directory. The test framework uses Python2 therefore this script also needs to be Python2 compatible.

hugueskamba · 2019-10-21T13:06:56Z

This force-push removes usage of the pathlib package as it is not listed as a required package in the requirements.txt file of Mbed OS.

0xc0170 · 2019-10-21T13:09:24Z

CI restarted

mbed-ci · 2019-10-21T15:44:51Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 9
Build artifacts

ciarmcom requested review from a team, evedon, jamesbeyond and maclobdell September 6, 2019 09:00

ciarmcom added the needs: review label Sep 6, 2019

hugueskamba force-pushed the hk-no-float-validation branch from 22c99f6 to f29cf7c Compare September 6, 2019 09:38

0xc0170 removed request for a team and maclobdell September 6, 2019 10:01

0xc0170 requested changes Sep 6, 2019

View reviewed changes

tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved

tools/test/examples/examples.py Outdated Show resolved Hide resolved

tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved

tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved

0xc0170 requested a review from a team September 6, 2019 10:45

hugueskamba force-pushed the hk-no-float-validation branch from 6a9d989 to 0944477 Compare September 6, 2019 12:37

0xc0170 added the do not merge label Sep 6, 2019

hugueskamba force-pushed the hk-no-float-validation branch from 0944477 to f9aadc4 Compare September 6, 2019 14:21

0xc0170 added the needs: CI label Oct 18, 2019

hugueskamba force-pushed the hk-no-float-validation branch from 320a8b7 to e230ca1 Compare October 18, 2019 13:39

hugueskamba changed the title ~~Test builds with minimal-printf and optional check for floats post-build~~ Move script to check for floats and make it Python 2 compatible Oct 18, 2019

hugueskamba force-pushed the hk-no-float-validation branch from e230ca1 to fdf6612 Compare October 18, 2019 13:42

0xc0170 added needs: work and removed needs: CI labels Oct 21, 2019

hugueskamba force-pushed the hk-no-float-validation branch from fdf6612 to 7871489 Compare October 21, 2019 12:15

0xc0170 added needs: CI and removed needs: work labels Oct 21, 2019

Move script to check for floats and make it Python 2 compatible.

c712d2f

All scripts pertaining to example projects tests should be in the same directory. The test framework uses Python2 therefore this script also needs to be Python2 compatible.

hugueskamba force-pushed the hk-no-float-validation branch from 7871489 to c712d2f Compare October 21, 2019 13:05

0xc0170 added ready for merge release-version: 5.14.2 and removed needs: CI labels Oct 22, 2019

0xc0170 merged commit 5eeeaca into ARMmbed:master Oct 22, 2019

0xc0170 removed the ready for merge label Oct 22, 2019

hugueskamba deleted the hk-no-float-validation branch October 23, 2019 07:02

Move script to check for floats and make it Python 2 compatible #11429

Move script to check for floats and make it Python 2 compatible #11429

Uh oh!

Conversation

hugueskamba commented Sep 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Sep 6, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xc0170 commented Sep 6, 2019

Uh oh!

0xc0170 commented Sep 6, 2019

Uh oh!

hugueskamba commented Sep 6, 2019

Uh oh!

hugueskamba commented Sep 6, 2019

Uh oh!

hugueskamba commented Oct 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Oct 18, 2019

Uh oh!

mbed-ci commented Oct 18, 2019

Test run: FAILED

Uh oh!

hugueskamba commented Oct 18, 2019

Test run: FAILED

Uh oh!

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Oct 21, 2019

Uh oh!

hugueskamba commented Oct 21, 2019

Uh oh!

0xc0170 commented Oct 21, 2019

Uh oh!

mbed-ci commented Oct 21, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Oct 21, 2019

Uh oh!

hugueskamba commented Oct 21, 2019

Uh oh!

0xc0170 commented Oct 21, 2019

Uh oh!

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hugueskamba commented Sep 6, 2019 •

edited

Loading

hugueskamba commented Oct 18, 2019 •

edited

Loading