M263: Enlarge LPTICKER_DELAY_TICKS for safe #11380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Nuvoton targets, lp_ticker_set_interrupt(...) needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). Enlarge LPTICKER_DELAY_TICKS to 4 from 3 to address this boundary case.
Member
|
@ccli8, thank you for your changes. |
0xc0170
approved these changes
Sep 2, 2019
Contributor
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
Contributor
|
CI restarted |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Contributor
|
Because of 5.14.0-rc1 CI jobs, we aborted CI job here. We will restart once 5.14.0rc1 is ready. |
Contributor
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #11021 and applies on NUMAKER_IOT_M263A.
lp_ticker_set_interrupt(...)needs around 3 lp-ticker ticks to take effect. It may miss when current tick and match tick are very close (see hal/LowPowerTickerWrapper.cpp). This PR enlargesLPTICKER_DELAY_TICKSto 4 from 3 to address this boundary case.Related PR
Continuation of #11021 and applies on M263 target
Pull request type