Mbed 2 builds are broken (was: ff_lpc546xx: Library name 'platform' is not unique)

[gorazdko]

Compiling example https://os.mbed.com/teams/mbed/code/mbed_blinky/ in online compiler for target FF_LPC546XX results in error:

Error: Library name 'platform' is not unique (defined in '/extras/mbed_7130f322cb7e/TARGET_LPC546XX/mbed_lib.json' and '/extras/mbed_7130f322cb7e/TARGET_FF_LPC546XX/mbed_lib.json')

Compiling examples with mbed-os works fine.

See PR #5876 for details

[0xc0170]

IS this happening only in the online compiler ? Offline all works - for instance exporting to an IDE or using mbed cli?

what is in those 2 json files?
[Mirrored to Jira]

[gorazdko]

mbed_lib.json is:

{
    "name": "platform",
    "config": {
        "stdio-convert-newlines": {
            "help": "Enable conversion to standard newlines on stdin/stdout",
            "value": false
        },

        "stdio-baud-rate": {
            "help": "Baud rate for stdio",
            "value": 9600
        },

        "stdio-flush-at-exit": {
            "help": "Enable or disable the flush of standard I/O's at exit.",
            "value": true
        },

        "default-serial-baud-rate": {
            "help": "Default baud rate for a Serial or RawSerial instance (if not specified in the constructor)",
            "value": 9600
        }
    },
    "target_overrides": {
        "EFM32": {
            "stdio-baud-rate": 115200
        },
        "EFR32": {
            "stdio-baud-rate": 115200
        }
    }
}

I cannot compile with mbed-cli because the target name is not found which is another bug:

C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky\mbed>mbed update 7130f322cb7e
[mbed] Updating library "mbed" to rev #7130f322cb7e

C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky\mbed>cd ..

C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky>mbed compile -t ARM -m FF_LPC546XX
WARNING: MBED_ARM_PATH set as environment variable but doesn't exist
usage: make.py [-h] [-m MCU] [-t TOOLCHAIN] [--color] [--cflags CFLAGS]
               [--asmflags ASMFLAGS] [--ldflags LDFLAGS] [-c]
               [--profile PROFILE] [--app-config APP_CONFIG] [-p PROGRAM]
               [-n PROGRAM] [-j JOBS] [-v] [--silent] [-D MACROS]
               [-S [{matrix,toolchains,targets}]] [-f GENERAL_FILTER_REGEX]
               [--stats-depth STATS_DEPTH] [--automated] [--host HOST_TEST]
               [--extra EXTRA] [--peripherals PERIPHERALS]
               [--dep DEPENDENCIES] [--source SOURCE_DIR]
               [--duration DURATION] [--build BUILD_DIR] [-N ARTIFACT_NAME]
               [-d DISK] [-s SERIAL] [-b BAUD] [-L] [--rpc] [--usb] [--dsp]
               [--testlib] [--build-data BUILD_DATA] [-l LINKER_SCRIPT]
make.py: error: argument -m/--mcu: FF_LPC546XX is not a supported MCU. Supported MCUs are:
ARCH_BLE,              ARCH_BLE_BOOT,         ARCH_BLE_OTA,
ARCH_GPRS,             ARCH_LINK,             ARCH_LINK_BOOT,
ARCH_LINK_OTA,         ARCH_MAX,              ARCH_PRO,
ARM_BEETLE_SOC,        ARM_CM3DS_MPS2,        ARM_IOTSS_BEID,
ARM_MPS2_M0,           ARM_MPS2_M0P,          ARM_MPS2_M1,
ARM_MPS2_M3,           ARM_MPS2_M4,           ARM_MPS2_M7,
B96B_F446VE,           BLUEPILL_F103C8,       DELTA_DFBM_NQ620,
DELTA_DFCM_NNN40,      DELTA_DFCM_NNN40_BOOT, DELTA_DFCM_NNN40_OTA,
DELTA_DFCM_NNN50,      DELTA_DFCM_NNN50_BOOT, DELTA_DFCM_NNN50_OTA,
DISCO_F051R8,          DISCO_F100RB,          DISCO_F303VC,
DISCO_F334C8,          DISCO_F401VC,          DISCO_F407VG,
DISCO_F413ZH,          DISCO_F429ZI,          DISCO_F469NI,
DISCO_F746NG,          DISCO_F769NI,          DISCO_L053C8,
DISCO_L072CZ_LRWAN1,   DISCO_L475VG_IOT01A,   DISCO_L476VG,
EFM32GG_STK3700,       EFM32HG_STK3400,       EFM32LG_STK3600,
EFM32PG12_STK3402,     EFM32PG_STK3401,       EFM32WG_STK3800,
EFM32ZG_STK3200,       ELEKTOR_COCORICO,      ELMO_F411RE,
FF1705_L151CC,         HEXIWEAR,              HRM1017,
HRM1017_BOOT,          HRM1017_OTA,           K20D50M,
K22F,                  K64F,                  K66F,
K82F,                  KL05Z,                 KL25Z,
KL26Z,                 KL27Z,                 KL43Z,
KL46Z,                 KL82Z,                 KW24D,
KW41Z,                 LPC1114,               LPC11C24,
LPC11U24,              LPC11U24_301,          LPC11U34_421,
LPC11U35_401,          LPC11U35_501,          LPC11U35_501_IBDAP,
LPC11U35_Y5_MBUG,      LPC11U37H_401,         LPC11U37_501,
LPC11U68,              LPC1347,               LPC1549,
LPC1768,               LPC1769,               LPC4088,
LPC4088_DM,            LPC4330_M0,            LPC4330_M4,
LPC4337,               LPC54114,              LPC546XX,
LPC810,                LPC812,                LPC824,
LPCCAPPUCCINO,         MAX32600MBED,          MAX32620HSP,
MAX32625MBED,          MAX32625NEXPAQ,        MAX32630FTHR,
MAXWSNENV,             MCU_LPC4088,           MICRONFCBOARD,
MOTE_L152RC,           MTM_MTCONNECT04S,      MTM_MTCONNECT04S_BOOT,
MTM_MTCONNECT04S_OTA,  MTS_DRAGONFLY_F411RE,  MTS_GAMBIT,
MTS_MDOT_F405RG,       MTS_MDOT_F411RE,       NCS36510,
NRF51822,              NRF51822_BOOT,         NRF51822_OTA,
NRF51822_Y5_MBUG,      NRF51_DK,              NRF51_DK_BOOT,
NRF51_DK_LEGACY,       NRF51_DK_OTA,          NRF51_DONGLE,
NRF51_DONGLE_BOOT,     NRF51_DONGLE_LEGACY,   NRF51_DONGLE_OTA,
NRF51_MICROBIT,        NRF51_MICROBIT_B,      NRF51_MICROBIT_BOOT,
NRF51_MICROBIT_B_BOOT, NRF51_MICROBIT_B_OTA,  NRF51_MICROBIT_OTA,
NRF52840_DK,           NRF52_DK,              NUCLEO_F030R8,
NUCLEO_F031K6,         NUCLEO_F042K6,         NUCLEO_F070RB,
NUCLEO_F072RB,         NUCLEO_F091RC,         NUCLEO_F103RB,
NUCLEO_F207ZG,         NUCLEO_F302R8,         NUCLEO_F303K8,
NUCLEO_F303RE,         NUCLEO_F303ZE,         NUCLEO_F334R8,
NUCLEO_F401RE,         NUCLEO_F410RB,         NUCLEO_F411RE,
NUCLEO_F412ZG,         NUCLEO_F429ZI,         NUCLEO_F439ZI,
NUCLEO_F446RE,         NUCLEO_F446ZE,         NUCLEO_F746ZG,
NUCLEO_F756ZG,         NUCLEO_F767ZI,         NUCLEO_L011K4,
NUCLEO_L031K6,         NUCLEO_L053R8,         NUCLEO_L073RZ,
NUCLEO_L152RE,         NUCLEO_L432KC,         NUCLEO_L476RG,
NUCLEO_L486RG,         NUCLEO_L496ZG,         NUMAKER_PFM_M453,
NUMAKER_PFM_M487,      NUMAKER_PFM_NANO130,   NUMAKER_PFM_NUC472,
NZ32_SC151,            OC_MBUINO,             RBLAB_BLENANO,
RBLAB_BLENANO_BOOT,    RBLAB_BLENANO_OTA,     RBLAB_NRF51822,
RBLAB_NRF51822_BOOT,   RBLAB_NRF51822_OTA,    REALTEK_RTL8195AM,
RO359B,                RZ_A1H,                SAMD21G18A,
SAMD21J18A,            SAMG55J19,             SAML21J18A,
SAMR21G18A,            SARA_NBIOT_EVK,        SEEED_TINY_BLE,
SEEED_TINY_BLE_BOOT,   SEEED_TINY_BLE_OTA,    SILICA_SENSOR_NODE,
SSCI824,               Super_Target,          TB_SENSE_1,
TB_SENSE_12,           TEENSY3_1,             TMPM066,
TY51822R3,             TY51822R3_BOOT,        TY51822R3_OTA,
UBLOX_C027,            UBLOX_C030_N211,       UBLOX_C030_U201,
UBLOX_EVA_NINA,        UBLOX_EVK_NINA_B1,     UBLOX_EVK_ODIN_W2,
UBRIDGE,               USENSE,                VBLUNO51,
VBLUNO51_BOOT,         VBLUNO51_LEGACY,       VBLUNO51_OTA,
VBLUNO52,              VK_RZ_A1H,             WALLBOT_BLE,
WALLBOT_BLE_BOOT,      WALLBOT_BLE_OTA,       WIZWIKI_W7500,
WIZWIKI_W7500ECO,      WIZWIKI_W7500P,        XADOW_M0,
XBED_LPC1768,          XDOT_L151CC
[mbed] ERROR: "c:\python27\python.exe" returned error code 2.
[mbed] ERROR: Command "c:\python27\python.exe -u C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky\.temp\tools\make.py -t ARM -m FF_LPC546XX --source . --build .\BUILD\FF_LPC546XX\ARM" in "C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky"
---

C:\Users\Gorazd\Desktop\mbed-os-2-fflpc546xx\mbed-error_reporduce_in_cli\mbed_blinky>

FF_LPC546XX is definitely in targets.json locally and online.
[Mirrored to Jira]

[0xc0170]

From the log, I cannot spot FF_LPC546XX there.
But looking at the sha, latest mbed 2 version - it contains this target - https://os.mbed.com/users/mbed_official/code/mbed/file/7130f322cb7e/targets.json/ 😩

@theotherjimmy can you help?
[Mirrored to Jira]

[theotherjimmy]

@gorazdko This looks like the release contains a complete mbed implementation for both LPC546xx and FF_LPC546xx. That is a bit strange, because FF_LPC546xx does not contain the key "release_version". @adbridge This seems like a release mistake, could we look into correcting it?

@0xc0170 @gorazdko I need to update the mbed 2 tools to parse the new target. I'll do that this week. After I do that, you should be able to reproduce this offline as well.
[Mirrored to Jira]

[0xc0170]

@gorazdko This looks like the release contains a complete mbed implementation for both LPC546xx and FF_LPC546xx. That is a bit strange, because FF_LPC546xx does not contain the key "release_version". @adbridge This seems like a release mistake, could we look into correcting it?

Good catch 👍

@gorazdko #5344 - did not have release version labeled, intentional or should be fixed?
[Mirrored to Jira]

[theotherjimmy]

@0xc0170 Adding a release version would be a mistake as it would enforce this compiler error.
[Mirrored to Jira]

[gorazdko]

Hi, what is the status of this ticket?
[Mirrored to Jira]

[screamerbg]

@gorazdko @theotherjimmy The target definition for FF_LPC546XX in target.json must not inherit from LPC546XX, otherwise Mbed 2.0/Classic builds won't link due to duplicate symbols errors. E.g. due to the inheritance from existing target, both target build directories in the Mbed 2.0 release (TARGET_FF_LPC546XX and TARGET_LPC546XX) will be included, causing duplicate linker errors. I think that this is why you're seeing the mbed_lib.json errors as well, you just haven't gotten to the linker step for the duplicate linker errors.
[Mirrored to Jira]

[theotherjimmy]

@screamerbg I looked and the FF_... does not have release version 2 attached to it. My understanding was that: therefore it should not get it's own build of mbed 2
[Mirrored to Jira]

[screamerbg]

The parent target has 2 and 5 release versions, therefore it gets both. https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json

Also, we want Mbed 2 releases for this board :)
[Mirrored to Jira]

[gorazdko]

The target definition for FF_LPC546XX in target.json must not inherit from LPC546XX

So #5876 is OK then?
[Mirrored to Jira]

[screamerbg]

Yes. The PR is correct. You would have to wait for the next Mbed 2.0/Classic release until it starts working in the online IDE.
[Mirrored to Jira]

[gorazdko]

Thanks!
[Mirrored to Jira]