Tickers update should be atomic

[pan-]

Description

• Type: Bug

Bug

The function updating the current ticker value does not do it atomically, as a result concurrent updates of the ticker may corrupt the ticker value. This may happen if multiples thread read concurrently the ticker value.

Protecting the data structure from concurrent updates with a critical section may be a solution.

[0xc0170]

This may happen if multiples thread read concurrently the ticker value.

👍

Looking at the file who handles the critical section, caller does in most cases, invoking update time within critical section. The only case it fails is when reading the time as reported in ticker_read_us (I do not count initialize as that one is run once and at the end is event scheduled).

Protecting the data structure from concurrent updates with a critical section may be a solution.

@c1728p9 @SenRamakri @bulislaw please review

[NeilMacMullen]

This may happen if multiples thread read concurrently the ticker value.

FWIW, I believe this matches the scenario where I am seeing timer 'tearing'. I have a background thread that is polling an I2C device. and a foreground thread which is calling read_ms on a Timer object. The platform is Nordic RF52832 and the i2c_api platform code for this uses ticker_read_us to check for a timeout on clock-stretching slaves. (Added to address #4826)

[mprse]

Fix for this issue has been provided here: PR #5889.

[NeilMacMullen]

I've just patched this across to my build and initial impressions are that it has fixed the issue. Thanks!

[cmonr]

Closing since all PRs appear to be merged and issue appears to be fixed.