Fix Travis and README, enable Mbed OS PSA by default #94
Conversation
Commands for mbed-tools have been renamed since `.travis.yml` was first added to this repository.
LDong-Arm
changed the title
getting-started/mbed_app.json
Outdated
| "platform.stdio-convert-newlines": true, | ||
| "target.features_add" : ["EXPERIMENTAL_API"], | ||
| "target.features_add" : ["EXPERIMENTAL_API", "PSA"], | ||
| "target.extra_labels_add": ["MBED_PSA_SRV"], |
There was a problem hiding this comment.
Do we really need MBED_PSA_SRV? Shouldn't this example work also with a TF-M target?
README.md
Outdated
|
|
||
| ## Prerequisites | ||
| * Install <a href='https://github.com/ARMmbed/mbed-cli#installing-mbed-cli'>Mbed CLI</a> | ||
| This example enables Mbed OS PSA. It is compatible with **non-TF-M** targets, as TF-M has its own PSA implementation |
There was a problem hiding this comment.
This example should work with TF-M. If not, we need to understand why it doesn't and fix it.
There was a problem hiding this comment.
I've updated it. Hopefully we can get this PR in to unblock Travis, and #95 actually fixes TF-M support.
README.md
Outdated
|
|
||
| List of examples contained within this repository: | ||
| * Example code snippets for using the library, with [documentation](https://github.com/ARMmbed/mbed-crypto/blob/development/docs/getting_started.md). | ||
| This repository contains an example demonstrating the compilation and use of Mbed Crypto on Mbed OS. |
There was a problem hiding this comment.
Existing issue, but we should say "PSA Crypto" instead of "Mbed Crypto". The example is expected to work with any PSA crypto implementation.
There was a problem hiding this comment.
Good point. Shall we also rename this repo to mbed-os-example-psa-crypto? Existing links to the old names will be redirected by GitHub.
|
@Patater Yes the main issue here is TF-M doesn't provide |
To enable Mbed OS PSA on a non-TF-M target, a user only needs to add
`"target.extra_labels_add": ["MBED_PSA_SRV"]`
without having to touch `"target.features_add"` in `mbed_app.json`.
This slightly simplifies the manual configuration.
We can remove the call to |
|
This is now combined into #95 |
2 participants
Uh oh!
There was an error while loading. Please reload this page.