Skip to content

Ancestor check #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Ancestor check #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0870c8d
A version with the RN ancestor stuff
Jun 1, 2016
97fc6a6
Check if there is a focused field before trying to scroll to it
alvaromb Jun 2, 2016
ecbdfd7
Merge branch 'master' into ancestor_check
Jun 28, 2016
da27a8c
v0.1.2 with ancestor_check
Jun 28, 2016
6c181de
[Bug] Set keyboardSpace is 0 if viewIsInsideTabBar == false
Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/KeyboardAwareListView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ const KeyboardAwareListView = React.createClass({
this.setResetScrollToCoords(this.props.resetScrollToCoords)
},

getScrollHandle: function () {
return this.refs._rnkasv_keyboardView
},

render: function () {
return (
<ListView
Expand Down
14 changes: 11 additions & 3 deletions lib/KeyboardAwareMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* @flow */

import { PropTypes } from 'react'
import ReactNative, { TextInput, Keyboard } from 'react-native'
import ReactNative, { TextInput, Keyboard, UIManager } from 'react-native'
import TimerMixin from 'react-timer-mixin'

const _KAM_DEFAULT_TAB_BAR_HEIGHT = 49
Expand All @@ -24,7 +24,7 @@ const KeyboardAwareMixin = {

setViewIsInsideTabBar: function (viewIsInsideTabBar: bool) {
this.viewIsInsideTabBar = viewIsInsideTabBar
this.setState({keyboardSpace: _KAM_DEFAULT_TAB_BAR_HEIGHT})
this.setState({keyboardSpace: this.viewIsInsideTabBar ? _KAM_DEFAULT_TAB_BAR_HEIGHT : 0 })
},

setResetScrollToCoords: function (coords: {x: number, y: number}) {
Expand Down Expand Up @@ -53,7 +53,15 @@ const KeyboardAwareMixin = {
return
}
try {
this.scrollToFocusedInputWithNodeHandle(currentlyFocusedField)
UIManager.viewIsDescendantOf(
currentlyFocusedField,
this.getScrollHandle().getScrollResponder().getInnerViewNode(),
(isAncestor) => {
if (isAncestor) {
this.scrollToFocusedInputWithNodeHandle(currentlyFocusedField)
}
}
)
} catch (e) {

}
Expand Down
4 changes: 4 additions & 0 deletions lib/KeyboardAwareScrollView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ const KeyboardAwareScrollView = React.createClass({
this.setResetScrollToCoords(this.props.resetScrollToCoords)
},

getScrollHandle: function () {
return this.refs._rnkasv_keyboardView
},

render: function () {
return (
<ScrollView
Expand Down