-
Notifications
You must be signed in to change notification settings - Fork 58
DocumentTransform unit tests #79
DocumentTransform unit tests #79
Conversation
I'll happily fix these bugs, although I'm wondering what behavior exactly would we expect; which of the trivia should we keep, and which should we drop? IMHO, we should drop all except Second thing is, should namespace-nested usings also be dropped (as is), or should we leave them too? |
That all sounds good, with one response:
I don't care too much either way. I would tend toward including them. But as long as the code compiles I don't care too much. :) |
After reconsidering the implications, I'm going to drop all trivia, including if/else directives, regions and pragmas. Because generation is expected to be run for each compilation, and a given compilation has a defined set of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Yes, yes it does fix those two :) Glad to help. |
Validates bugs #29, #32 as "expected"
These are unit tests for
DocumentTransform.TransformAsync
which, for a given "document" string validate if it generates document equal to "expected" document string.In the current state they all pass. I think that it might be a better approach to first create a "working as-is" environment, and then add bugfixes separately.
edit after additional commits, this PR now: