fix: Update vector store file chunking strategy to use StaticChunkingStrategy #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64bit
reviewed
Jun 7, 2024
Reverted according to recent comments on #229, reasoning can be found on thread.
64bit
reviewed
Jun 7, 2024
64bit
reviewed
Jun 7, 2024
Related details can be found in PR #230
64bit
reviewed
Jun 7, 2024
…r store Related PR: #230 Co-authored-by: Himanshu Neema <[email protected]>
64bit
approved these changes
Jun 7, 2024
Owner
64bit
left a comment
64bit
left a comment
There was a problem hiding this comment.
Thank you for the PR and bug fixes!
harsh-98
pushed a commit
to harsh-98/async-openai
that referenced
this pull request
Sep 3, 2025
…Strategy (64bit#230) * fix: Update vector store file chunking strategy to use StaticChunkingStrategy This targets the changes mentioned in 64bit#229, because OpenAI requires a non-null name when creating a vector store. This also fixes attaching a file to a vector store, where it would fail to deserialize. Also adds a test for both errors to catch them during development in the future! 64bit#229 * bugfix: Made optional name field consistent to OpenAI spec Reverted according to recent comments on 64bit#229, reasoning can be found on thread. * chore: Modified redudant code in test Related details can be found in PR 64bit#230 * test: Update tests to double check for a failure in add file to vector store Related PR: 64bit#230 Co-authored-by: Himanshu Neema <[email protected]> --------- Co-authored-by: Himanshu Neema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets the changes mentioned in #229, because OpenAI requires a non-null name when creating a vector store. This also fixes attaching a file to a vector store, where it would fail to deserialize. Also adds a test for both errors to catch them during development in the future!
Fixes #229