feat: support uniswap v4 backGeoOracle #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented in the same way as the UniswapV4LikeOracle, but using the BackGeoOracle Uniswap V4 oracle hook
|
Related to #226 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Support the Uniswap V4 BackGeoOracle hook. It is implemented in the same way as the UniswapV4LikeOracle, thus reading from the
slot0instead of using the oracle'sobservemethod for simplicity. The oracle has a maximum tick delta within a single block, so it is safer from manipulation compared to other Uniswap pools.Related Issue/Ticket:
Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact
Risk:
slot0can be manipulated within certain tick deltas (max ≃15% price movement tolerance within a single block). An improved approach would be to use a 1-minute twap via the hook'sobservemethod (still gas efficient).