Skip to content

fix(async): handle close of packet stream to avoid panic #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2023
Merged

fix(async): handle close of packet stream to avoid panic #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions socketio/src/asynchronous/client/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,14 +343,10 @@ impl ClientBuilder {
// Use thread to consume items in iterator in order to call callbacks
tokio::runtime::Handle::current().spawn(async move {
let mut stream = socket_clone.as_stream();
loop {
// tries to restart a poll cycle whenever a 'normal' error occurs,
// it just logs on network errors, in case the poll cycle returned
// `Result::Ok`, the server receives a close frame so it's safe to
// terminate
if let Some(e @ Err(Error::IncompleteResponseFromEngineIo(_))) = stream.next().await
{
trace!("Network error occured: {}", e.unwrap_err());
// Consume the stream until it returns None and the stream is closed.
while let Some(item) = stream.next().await {
if let e @ Err(Error::IncompleteResponseFromEngineIo(_)) = item {
trace!("Network error occurred: {}", e.unwrap_err());
}
}
});
Expand Down