fix: linting issues for GitHub Actions CI

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-cafc9ebb-a4d3-4752-a6eb-d41c8bd2b149

Author: rhnvrm

app/app.go.backup

@@ -126,7 +126,7 @@ func (m *Manager) GetAuthenticatedClient(sessionID string) (*kiteconnect.Client,
 	}
 
 	if time.Now().After(session.Credentials.ExpiresAt) {
-		return nil, errors.New("Kite session has expired (24-hour limit). Please use the login tool to refresh")
+		return nil, errors.New("kite session has expired (24-hour limit). Please use the login tool to refresh")
 	}
 
 	client := kiteconnect.New(m.apiKey)
@@ -213,4 +213,4 @@ func setupTemplates() (map[string]*template.Template, error) {
 		out[templateName] = templ
 	}
 	return out, nil
-}
+}

kc/manager.go

@@ -85,10 +85,6 @@ func TestNewManager(t *testing.T) {
 		t.Fatalf("Expected no error creating manager, got: %v", err)
 	}
 
-	if manager == nil {
-		t.Fatal("Expected non-nil manager")
-	}
-
 	if manager.apiKey != apiKey {
 		t.Errorf("Expected API key %s, got %s", apiKey, manager.apiKey)
 	}
@@ -273,4 +269,4 @@ func TestSessionSigner(t *testing.T) {
 	if verifiedSessionID != testSessionID {
 		t.Errorf("Expected verified session ID %s, got %s", testSessionID, verifiedSessionID)
 	}
-}
+}

kc/manager_test.go

@@ -275,7 +275,7 @@ func (sm *SessionManager) copySession(original *Session) *Session {
 		ExpiresAt:  original.ExpiresAt,
 		OAuthData:  original.OAuthData, // Shallow copy - assuming immutable
 	}
-	
+
 	// Deep copy credentials if present
 	if original.Credentials != nil {
 		copy.Credentials = &KiteCredentials{
@@ -284,6 +284,6 @@ func (sm *SessionManager) copySession(original *Session) *Session {
 			ExpiresAt:   original.Credentials.ExpiresAt,
 		}
 	}
-	
+
 	return copy
-}
+}

kc/session.go

@@ -172,4 +172,4 @@ func (s *SessionSigner) VerifyRedirectParams(redirectParams string) (string, err
 	}
 
 	return s.VerifySessionID(signedSessionID)
-}
+}

kc/session_signing.go

@@ -12,10 +12,6 @@ func TestNewSessionSigner(t *testing.T) {
 		t.Fatalf("Expected no error creating session signer, got: %v", err)
 	}
 
-	if signer == nil {
-		t.Fatal("Expected non-nil session signer")
-	}
-
 	if len(signer.secretKey) != 32 {
 		t.Errorf("Expected secret key length 32, got %d", len(signer.secretKey))
 	}
@@ -29,10 +25,6 @@ func TestNewSessionSignerWithKey(t *testing.T) {
 	testKey := []byte("test-key-32-bytes-long-for-hmac")
 	signer := NewSessionSignerWithKey(testKey)
 
-	if signer == nil {
-		t.Fatal("Expected non-nil session signer")
-	}
-
 	if len(signer.secretKey) != len(testKey) {
 		t.Errorf("Expected secret key length %d, got %d", len(testKey), len(signer.secretKey))
 	}
@@ -196,4 +188,4 @@ func TestValidateSessionID(t *testing.T) {
 	if err != nil {
 		t.Errorf("Expected no error for valid session ID, got: %v", err)
 	}
-}
+}

kc/session_signing_test.go

@@ -15,10 +15,6 @@ import (
 func TestNewSessionManager(t *testing.T) {
 	manager := NewSessionManager(testLogger())
 
-	if manager == nil {
-		t.Fatal("Expected non-nil manager")
-	}
-
 	if manager.sessionDuration != DefaultSessionDuration {
 		t.Errorf("Expected default duration of %v, got %v", DefaultSessionDuration, manager.sessionDuration)
 	}
@@ -101,10 +97,6 @@ func TestGetOrCreate(t *testing.T) {
 		t.Error("Expected isNew to be true for first call")
 	}
 
-	if session == nil {
-		t.Fatal("Expected non-nil session")
-	}
-
 	if session.ID != sessionID {
 		t.Errorf("Expected session ID %s, got %s", sessionID, session.ID)
 	}
@@ -123,7 +115,7 @@ func TestGetOrCreate(t *testing.T) {
 	if session2.ID != session.ID {
 		t.Error("Expected sessions to have the same ID")
 	}
-	
+
 	if session2.CreatedAt != session.CreatedAt {
 		t.Error("Expected sessions to have the same CreatedAt time")
 	}
@@ -385,7 +377,7 @@ func TestConcurrentSessionCreation(t *testing.T) {
 func TestConcurrentSessionTermination(t *testing.T) {
 	manager := NewSessionManager(testLogger())
 	const numGoroutines = 20
-	
+
 	// Create multiple sessions
 	sessionIDs := make([]string, numGoroutines)
 	for i := 0; i < numGoroutines; i++ {
@@ -476,4 +468,4 @@ func TestConcurrentCleanup(t *testing.T) {
 	if remaining != 0 {
 		t.Errorf("Expected 0 sessions remaining after cleanup, got %d", remaining)
 	}
-}
+}

kc/session_test.go

@@ -272,4 +272,4 @@ func PaginatedToolHandler[T any](manager *kc.Manager, toolName string, apiCall f
 			return handler.MarshalResponse(responseData, toolName)
 		})
 	}
-}
+}

mcp/common.go

@@ -243,4 +243,4 @@ func (*OrderHistoryTool) Handler(manager *kc.Manager) server.ToolHandlerFunc {
 			return handler.MarshalResponse(orderHistory, "get_order_history")
 		})
 	}
-}
+}

mcp/get_tools.go

@@ -278,4 +278,4 @@ func (*OHLCTool) Handler(manager *kc.Manager) server.ToolHandlerFunc {
 			return handler.MarshalResponse(ohlc, "get_ohlc")
 		})
 	}
-}
+}