From 76ce88223faf2312dce3003a82530180355e929d Mon Sep 17 00:00:00 2001 From: Marc Reilly Date: Thu, 28 Aug 2025 13:24:08 +1000 Subject: [PATCH 1/2] sensor: shell_battery: fix current value display The sensor interface gives current channel values in Amps, but the "I" (current) value is displayed in mA, so needs to be converted accordingly. Signed-off-by: Marc Reilly --- drivers/sensor/shell_battery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/sensor/shell_battery.c b/drivers/sensor/shell_battery.c index babdd7315ce19..8f96ff72ecb23 100644 --- a/drivers/sensor/shell_battery.c +++ b/drivers/sensor/shell_battery.c @@ -94,7 +94,8 @@ static int cmd_battery(const struct shell *sh, size_t argc, char **argv) volt.val1, volt.val2 / 10000); shell_print(sh, "V-desired: %d.%02d V", v_desired.val1, v_desired.val2 / 10000); - shell_fprintf_normal(sh, "I: %d mA", current.val1); + shell_fprintf_normal(sh, "I: %d mA", + (current.val1 * 1000) + (current.val2 / 1000)); if (current.val1 > 0) { shell_fprintf_normal(sh, " (CHG)"); } else if (current.val1 < 0) { From 132ed2e1ec82d71159f10af549f89461799311b9 Mon Sep 17 00:00:00 2001 From: Marc Reilly Date: Thu, 28 Aug 2025 13:24:56 +1000 Subject: [PATCH 2/2] sensor: shell_battery: display labels for capacity are mAh Update the units labels to be mAh Signed-off-by: Marc Reilly --- drivers/sensor/shell_battery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/sensor/shell_battery.c b/drivers/sensor/shell_battery.c index 8f96ff72ecb23..fa17161347d1b 100644 --- a/drivers/sensor/shell_battery.c +++ b/drivers/sensor/shell_battery.c @@ -110,10 +110,10 @@ static int cmd_battery(const struct shell *sh, size_t argc, char **argv) shell_print(sh, "Charge: %d %%", charge.val1); shell_print(sh, "V-design: %d.%02d V", v_design.val1, v_design.val2 / 10000); - shell_print(sh, "Remaining: %d mA", + shell_print(sh, "Remaining: %d mAh", charge_remain.val1); - shell_print(sh, "Cap-full: %d mA", cap.val1); - shell_print(sh, "Design: %d mA", nom_cap.val1); + shell_print(sh, "Cap-full: %d mAh", cap.val1); + shell_print(sh, "Design: %d mAh", nom_cap.val1); shell_print(sh, "Time full: %dh:%02d", full.val1 / 60, full.val1 % 60); shell_print(sh, "Time empty: %dh:%02d",