Skip to content

Conversation

@ruudboon
Copy link
Contributor

@ruudboon ruudboon commented Dec 10, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Added PHP 7.4 to app veyor

Thanks

Added PHP 7.4 to app veyor
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #85 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development      #85   +/-   ##
============================================
  Coverage        80.52%   80.52%           
============================================
  Files                5        5           
  Lines             6538     6538           
============================================
  Hits              5265     5265           
  Misses            1273     1273
Flag Coverage Δ
#unittests 80.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be4075...c95ae6f. Read the comment docs.

@ruudboon ruudboon requested a review from sergeyklay December 10, 2019 17:53
@ruudboon
Copy link
Contributor Author

@sergeyklay When this is merged, can we somehow trigger a 7.4 windows build on the v1.3.2 tag so we can add it to the release?

@sergeyklay
Copy link
Contributor

@ruudboon We'll need a new release. Let me do it

@ruudboon
Copy link
Contributor Author

@sergeyklay Ok. Thnx

@sergeyklay sergeyklay merged commit 5267245 into development Dec 10, 2019
@sergeyklay sergeyklay deleted the ruudboon-patch-1 branch December 10, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants