Skip to content

fix: throw error if unsupported options passed in vue < 2.3 #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2018
Merged

fix: throw error if unsupported options passed in vue < 2.3 #910

merged 2 commits into from
Aug 9, 2018

Conversation

@eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented Aug 8, 2018

We don't support localVue, stubs, or mocks in Vue < 2.3 due to a bug in Vue.

  • Throw an error if a user tries to use the options with Vue < 2.3
  • Add false option to mocks andstubs, so that user can overwrite them in mounting options

@eddyerburgh eddyerburgh merged commit e8d9547 into vuejs:dev Aug 9, 2018
@eddyerburgh eddyerburgh deleted the throw-error-for-vue-2.3 branch August 9, 2018 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eddyerburgh