feat: element, vnode, vm, and options are read-only #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
Jun 23, 2018
packages/test-utils/src/wrapper.js
Outdated
| set: () => {} | ||
| }) | ||
| } | ||
| const freezedOptions = Object.freeze(options) |
Member
There was a problem hiding this comment.
Please changed freezedOptions to frozenOptions
eddyerburgh
requested changes
Jun 23, 2018
Member
eddyerburgh
left a comment
eddyerburgh
left a comment
There was a problem hiding this comment.
Thanks, looks fine. One minor change of a variable named (freezed is non-standard English). Otherwise I'm happy to merge
Contributor
Author
|
Thank you for pointing out. |
eddyerburgh
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since vm, element and options are read-only in the type definition, this changes them to read-only.
Since the element property is read-only, this removes unnecessary checks.
This is related to #725.