Refactor: refactor stub-components.js #544
Conversation
| if (component.extendOptions && component.extendOptions.components) { | ||
| stubComponents(component.extendOptions.components, stubbedComponents) | ||
| } | ||
| export function createComponentStubs (components: Object = {}, stubOptions: Object): Object { |
There was a problem hiding this comment.
Personally I think public methods should be moved to top of file. Didn't do it to satisfy git blame as much as possible
There was a problem hiding this comment.
I don't think we should move the position of functions. Most files in this project have public functions at the bottom of the files
There was a problem hiding this comment.
Ok, let it stay like that
packages/shared/stub-components.js
Outdated
| delete components[c]._Ctor // eslint-disable-line no-param-reassign | ||
| }) | ||
| return components | ||
| if (Vue.config.ignoredElements) { |
There was a problem hiding this comment.
Do we need it ? I copied it from original source.
There was a problem hiding this comment.
I don't think we do. you can remove it :)
| throwError('vueTemplateCompiler is undefined, you must pass components explicitly if vue-template-compiler is undefined') | ||
| } | ||
|
|
||
| if (containsTemplateWithCircularReference(stubOptions, components)) { |
There was a problem hiding this comment.
This is actually causing bugs for some users. The check is not strict enough, so I've removed the check in the source code for the moment. Could you either remove this code, or improve the code to handle edge cases like: UnreadState: '<div data-stub-unread-state v-bind="$props"><slot/></div>'
|
Thanks :) |
* Revert "refactor: refactor stub-components.js (#544)" This reverts commit db5e07e. * Revert "refactor: refactor add-slots.js (#556)" This reverts commit ce9e1bf. * delete packages/test-utils/src/shallow.js * add functions * add type SlotValue * add test * fix slotValue * fix validateEnvironment * add test * fix lint * Update slots.spec.js
2 participants
Pull request contains changes like