Skip to content

fix: use correct event type for checkbox v-model handler #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 28, 2018
Merged

fix: use correct event type for checkbox v-model handler #1083

merged 5 commits into from
Dec 28, 2018

Conversation

@eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented Dec 27, 2018

  • Use appropriate event to trigger v-model in setChecked
  • Remove warnings from setValue and setChecked
  • Use semver library to determine correct event

Fixes #1071

@eddyerburgh eddyerburgh changed the title feat: stop using instance options fix: use correct event type for checkbox v-model handler Dec 27, 2018
@eddyerburgh eddyerburgh merged commit ef66c26 into vuejs:dev Dec 28, 2018
@eddyerburgh eddyerburgh deleted the fix-set-checked branch December 28, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eddyerburgh