Skip to content

Commit 8fb9556

Browse files
author
Release Manager
committed
sagemathgh-36987: Doing some cleanup on Littelmann paths <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> We do some cleanup on Littelmann paths by allowing greater input (including covering a surprising case when passing in a Cartan type and a weight for finite type), some PEP8 stuff, some doc formatting, commenting out assert statements, and other misc improvements. This is not necessarily meant to be comprehensive, but it moves things in the right direction. The most important thing is fixing the surprising input behavior. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36987 Reported by: Travis Scrimshaw Reviewer(s): Ben Salisbury
2 parents b5528bc + b068353 commit 8fb9556

File tree

1 file changed

+108
-87
lines changed

1 file changed

+108
-87
lines changed

0 commit comments

Comments
 (0)