Skip to content

Road to sf4 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2017
Merged

Road to sf4 #25

merged 2 commits into from
Nov 29, 2017

Conversation

@tyx
Copy link
Member

@tyx tyx commented Nov 27, 2017

Replace #24

@tyx tyx self-assigned this Nov 27, 2017
@tyx tyx mentioned this pull request Nov 27, 2017
Closed
@tyx tyx force-pushed the feature/road-to-sf4 branch from 3dcd643 to 4b2a27f Compare November 27, 2017 15:48
@tyx tyx force-pushed the feature/road-to-sf4 branch from 4b2a27f to 14fc08d Compare November 27, 2017 15:57
@tyx tyx requested a review from shouze November 27, 2017 16:00
shouze
shouze approved these changes Nov 29, 2017
View reviewed changes
Copy link
Member

@shouze shouze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shouze shouze merged commit dd5709d into ubirak:master Nov 29, 2017
@tyx tyx deleted the feature/road-to-sf4 branch November 30, 2017 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shouze shouze shouze approved these changes

Assignees

@tyx tyx

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tyx @shouze