Skip to content

Commit ca4fb89

Browse files
Yonglong Lidavem330
authored andcommitted
mptcp: add MSG_PEEK support
This patch adds support for MSG_PEEK flag. Packets are not removed from the receive_queue if MSG_PEEK set in recv() system call. Acked-by: Paolo Abeni <[email protected]> Signed-off-by: Yonglong Li <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 987858e commit ca4fb89

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

net/mptcp/protocol.c

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1745,10 +1745,10 @@ static int __mptcp_recvmsg_mskq(struct mptcp_sock *msk,
17451745
struct msghdr *msg,
17461746
size_t len, int flags)
17471747
{
1748-
struct sk_buff *skb;
1748+
struct sk_buff *skb, *tmp;
17491749
int copied = 0;
17501750

1751-
while ((skb = skb_peek(&msk->receive_queue)) != NULL) {
1751+
skb_queue_walk_safe(&msk->receive_queue, skb, tmp) {
17521752
u32 offset = MPTCP_SKB_CB(skb)->offset;
17531753
u32 data_len = skb->len - offset;
17541754
u32 count = min_t(size_t, len - copied, data_len);
@@ -1766,15 +1766,18 @@ static int __mptcp_recvmsg_mskq(struct mptcp_sock *msk,
17661766
copied += count;
17671767

17681768
if (count < data_len) {
1769-
MPTCP_SKB_CB(skb)->offset += count;
1769+
if (!(flags & MSG_PEEK))
1770+
MPTCP_SKB_CB(skb)->offset += count;
17701771
break;
17711772
}
17721773

1773-
/* we will bulk release the skb memory later */
1774-
skb->destructor = NULL;
1775-
msk->rmem_released += skb->truesize;
1776-
__skb_unlink(skb, &msk->receive_queue);
1777-
__kfree_skb(skb);
1774+
if (!(flags & MSG_PEEK)) {
1775+
/* we will bulk release the skb memory later */
1776+
skb->destructor = NULL;
1777+
msk->rmem_released += skb->truesize;
1778+
__skb_unlink(skb, &msk->receive_queue);
1779+
__kfree_skb(skb);
1780+
}
17781781

17791782
if (copied >= len)
17801783
break;
@@ -2053,7 +2056,8 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
20532056
pr_debug("msk=%p data_ready=%d rx queue empty=%d copied=%d",
20542057
msk, test_bit(MPTCP_DATA_READY, &msk->flags),
20552058
skb_queue_empty_lockless(&sk->sk_receive_queue), copied);
2056-
mptcp_rcv_space_adjust(msk, copied);
2059+
if (!(flags & MSG_PEEK))
2060+
mptcp_rcv_space_adjust(msk, copied);
20572061

20582062
release_sock(sk);
20592063
return copied;

0 commit comments

Comments
 (0)