Skip to content

Commit 4738ef6

Browse files
Clement HoClement Ho
authored andcommitted
Merge branch '60141-mr-resolve-conflicts-file-headers-bad-positioning-on-scroll' into 'master'
Resolve "MR resolve conflicts file headers bad positioning on scroll" Closes #60141 See merge request gitlab-org/gitlab-ce!31991
2 parents 4eecb0a + 98949a1 commit 4738ef6

File tree

2 files changed

+33
-0
lines changed

2 files changed

+33
-0
lines changed

app/assets/stylesheets/pages/diff.scss

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,14 @@
22
.diff-file {
33
margin-bottom: $gl-padding;
44

5+
&.conflict {
6+
border-top: 1px solid $border-color;
7+
}
8+
59
.file-title,
610
.file-title-flex-parent {
11+
border-top-left-radius: $border-radius-default;
12+
border-top-right-radius: $border-radius-default;
713
cursor: pointer;
814

915
@media (min-width: map-get($grid-breakpoints, md)) {
@@ -67,6 +73,28 @@
6773
}
6874
}
6975

76+
@media (min-width: map-get($grid-breakpoints, md)) {
77+
&.conflict .file-title,
78+
&.conflict .file-title-flex-parent {
79+
top: $header-height;
80+
}
81+
82+
.with-performance-bar &.conflict .file-title,
83+
.with-performance-bar &.conflict .file-title-flex-parent {
84+
top: $header-height + $performance-bar-height;
85+
}
86+
87+
.with-system-header &.conflict .file-title,
88+
.with-system-header &.conflict .file-title-flex-parent {
89+
top: $header-height + $system-header-height;
90+
}
91+
92+
.with-system-header.with-performance-bar &.conflict .file-title,
93+
.with-system-header.with-performance-bar &.conflict .file-title-flex-parent {
94+
top: $header-height + $performance-bar-height + $system-header-height;
95+
}
96+
}
97+
7098
.diff-content {
7199
background: $white-light;
72100
color: $gl-text-color;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
title: Fix file header style and position during scroll in a merge conflict resolution
3+
merge_request: 31991
4+
author:
5+
type: fixed

0 commit comments

Comments
 (0)