expose downsampleRaw function for testing purpose
#4248
Unanswered
yeya24
asked this question in
Questions & Answers
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Now in Thanos codebase, it is hard to create a downsampled block for testing directly. However, this is very much needed in the E2E tests or other unit tests.
I propose to export
downsample.downsampleRawmethod. The current code is:downsampleRawwill be renamed toDownsampleRawanddata []samplewill be changed todata []tsdbutil.Sample. This is an interface type and is much better for usability. Any thoughts about it?Beta Was this translation helpful? Give feedback.
All reactions