feat: change budget alerts to alarm by forecast #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanini-ciandt
requested review from
rjerrems,
gtsorbo and
a team
as code owners
rjerrems
reviewed
Nov 27, 2023
rjerrems
reviewed
Nov 27, 2023
rjerrems
reviewed
Nov 27, 2023
rjerrems
reviewed
Nov 27, 2023
rjerrems
reviewed
Nov 27, 2023
rjerrems
approved these changes
Nov 27, 2023
…rraform-example-foundation into feature/budget-alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to change the behavior of all the existing budget alerts.
Modified threshold rules: a single alarm when 120% of forecasted is spent;
Current threshold rules: multiple alarms (50%, 75%, 90%, 95%) based on the actual value spent.