Skip to content

Conversation

jtzero
Copy link
Contributor

@jtzero jtzero commented May 3, 2023

Description

changes data type of variable "instance_iam_role_use_name_prefix" to bool

Motivation and Context

Is to align the correct data type, the result in putting in a string

Error: Incorrect condition type
│
│   on .terraform/modules/pull.batch/main.tf line 88, in resource "aws_iam_role" "instance":
│   88:   name        = var.instance_iam_role_use_name_prefix ? null : var.instance_iam_role_name
│     ├────────────────
│     │ var.instance_iam_role_use_name_prefix is "runner"
│
│ The condition expression must be of type bool.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
    I use this module in my workflow and just tested it locally
  • I have executed pre-commit run -a on my pull request
Terraform fmt............................................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

@jtzero jtzero changed the title changes instance_iam_role_use_name_prefix to correct data type fix: changes instance_iam_role_use_name_prefix to correct data type May 3, 2023
@jtzero jtzero changed the title fix: changes instance_iam_role_use_name_prefix to correct data type fix: Changes instance_iam_role_use_name_prefix to correct data type May 3, 2023
@bryantbiggs bryantbiggs changed the title fix: Changes instance_iam_role_use_name_prefix to correct data type fix: Change instance_iam_role_use_name_prefix to use correct data type May 3, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 08a13f1 into terraform-aws-modules:master May 3, 2023
antonbabenko pushed a commit that referenced this pull request May 3, 2023
### [2.0.1](v2.0.0...v2.0.1) (2023-05-03)

### Bug Fixes

* Change `instance_iam_role_use_name_prefix` to use correct data type ([#20](#20)) ([08a13f1](08a13f1))
@antonbabenko
Copy link
Member

This PR is included in version 2.0.1 🎉

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants