Skip to content

Commit 8227434

Browse files
committed
Remove deprecated pool properties
1 parent beea78a commit 8227434

File tree

2 files changed

+1
-35
lines changed

2 files changed

+1
-35
lines changed

CHANGELOG.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ v8.0.0 (2022-??-??)
99
[change] Duplicate column names will now be presented as an array even if the values are empty ((#1240)[https://github.com/tediousjs/node-mssql/pull/1240])
1010
[change] Update tarn pool dependency ((#1344)[https://github.com/tediousjs/node-mssql/pull/1344])
1111
[removed] Remove connection string parser helpers ((#1342)[https://github.com/tediousjs/node-mssql/pull/1342])
12+
[removed] Remove deprecated pool properties ((#1359)[https://github.com/tediousjs/node-mssql/pull/1359])
1213

1314
v7.2.1 (2021-08-19)
1415
-------------------

lib/base/connection-pool.js

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -388,41 +388,6 @@ class ConnectionPool extends EventEmitter {
388388
propagateCreateError: true
389389
}, this.config.pool)
390390
)
391-
const self = this
392-
Object.defineProperties(this.pool, {
393-
size: {
394-
get: () => {
395-
const message = 'the `size` property on pool is deprecated, access it directly on the `ConnectionPool`'
396-
self.emit('debug', message)
397-
process.emitWarning(message)
398-
return self.size
399-
}
400-
},
401-
available: {
402-
get: () => {
403-
const message = 'the `available` property on pool is deprecated, access it directly on the `ConnectionPool`'
404-
self.emit('debug', message)
405-
process.emitWarning(message)
406-
return self.available
407-
}
408-
},
409-
pending: {
410-
get: () => {
411-
const message = 'the `pending` property on pool is deprecate, access it directly on the `ConnectionPool`'
412-
self.emit('debug', message)
413-
process.emitWarning(message)
414-
return self.pending
415-
}
416-
},
417-
borrowed: {
418-
get: () => {
419-
const message = 'the `borrowed` property on pool is deprecated, access it directly on the `ConnectionPool`'
420-
self.emit('debug', message)
421-
process.emitWarning(message)
422-
return self.borrowed
423-
}
424-
}
425-
})
426391

427392
this._connecting = false
428393
this._connected = true

0 commit comments

Comments
 (0)