Skip to content
This repository was archived by the owner on Jan 2, 2021. It is now read-only.

Conversation

@mturley
Copy link
Contributor

@mturley mturley commented Nov 5, 2020

Resolves TanStack/query#1262.

If a consumer is using tooling to enforce accessibility such as react-axe, they may need to change what type of element the devtools are rendered inside in order to pass rules like https://dequeuniversity.com/rules/axe/4.0/region.

This PR adds a prop to <ReactQueryDevtools /> called containerElement which defaults to 'footer' and replaces the current <div /> rendered around the devtools panel.

@tannerlinsley tannerlinsley merged commit e2b7527 into tannerlinsley:master Nov 5, 2020
@mturley mturley deleted the allow-custom-container branch November 5, 2020 22:48
@tannerlinsley
Copy link
Owner

🎉 This PR is included in version 2.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReactQueryDevtools component triggers warning from axe-core

2 participants