Refactor ingestion helpers and expand tests

[tanakachitsamba]

Summary

• refactor the ingestion module into reusable helpers with stronger validation
• update Behave steps and scenarios to provide structured payloads and cover negative cases
• add pytest unit tests to exercise payload parsing and ingestion logic

Testing

• pytest

---

https://chatgpt.com/codex/tasks/task_e_68e42c0f3c5c83288826a82290ba83c0

[Copilot]

Pull Request Overview

This PR refactors the ingestion module into reusable helper functions with improved validation and error handling. It replaces the previous command-line based approach with structured payload parsing and adds comprehensive test coverage.

• Refactored add_documents.py into modular helper functions with type hints and proper validation
• Expanded BDD tests to cover negative scenarios and structured payloads using Behave tables
• Added comprehensive pytest unit tests for payload parsing and ingestion logic

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
add_documents.py	Complete refactor from command-line script to modular helpers with validation and error handling
bdd_tests.feature	Added structured test scenarios with tables and negative test cases
add_documents_bdd_tests.py	Updated Behave steps to use new helper functions and handle structured data
tests/test_add_documents.py	New pytest unit tests covering payload parsing and ingestion validation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The import is placed inside the function, but it's used in multiple functions. Consider moving this to the top-level imports for consistency and performance.

[tanakachitsamba]

@codex fix comments

[chatgpt-codex-connector]

Summary

• Resolved the optional python-dotenv dependency at module import time and added a clear fallback error when it is unavailable. add_documents.pyL5-L33
• Updated the pytest suite to load add_documents via importlib rather than mutating sys.path. tests/test_add_documents.pyL1-L21

Testing

• ✅ pytest

View task →